Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for possible race for new block post consensus processing. #4677

Closed
wants to merge 3 commits into from
Closed

Fix for possible race for new block post consensus processing. #4677

wants to merge 3 commits into from

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented May 24, 2024

Fix for possible race for new block post consensus processing.

@Frozen Frozen self-assigned this May 24, 2024
@sophoah
Copy link
Contributor

sophoah commented May 24, 2024

this PR seems to break consensus, travis tests are not moving

Waiting for localnet to boot...
Waiting for localnet to boot...
Localnet booted.
Waiting for epoch 2...
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@sophoah
Copy link
Contributor

sophoah commented May 28, 2024

could you explain why this PR may fix the possible race condition with the post consensus process ?

@Frozen
Copy link
Contributor Author

Frozen commented Jun 1, 2024 •
edited
Loading

could you explain why this PR may fix the possible race condition with the post consensus process ?

It removes https://github.com/harmony-one/harmony/pull/4677/files#diff-255a5cdd5516e7293e60a47a92503360676ddffb7e48e505598a589753b568c2L672 which execution is not predictable.

@ONECasey ONECasey requested a review from sophoah June 6, 2024 08:25
@Frozen Frozen marked this pull request as draft July 7, 2024 12:52
@Frozen
Copy link
Contributor Author

Frozen commented Aug 8, 2024

This PR is unstable, i will close it

@Frozen Frozen closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GheisMohammadi GheisMohammadi Awaiting requested review from GheisMohammadi

@sophoah sophoah Awaiting requested review from sophoah

Assignees

@Frozen Frozen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frozen @sophoah